Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: astropy landing should use labels vs partners #576

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 3, 2025

closes #575

This is just a tiny fix to make sure we're grabbing affiliated data from an editor curated field

@lwasser lwasser changed the title Fix: astropy landing shoould use labels vs partners Fix: astropy landing should use labels vs partners Mar 4, 2025
@pllim
Copy link
Contributor

pllim commented Mar 4, 2025

When I am previewing https://output.circle-artifacts.com/output/job/5646506d-b78e-4155-a44d-dd3788affb54/artifacts/0/_site/python-packages.html and click the Astropy button, I see this:

https://output.circle-artifacts.com/communities/astropy.html

{"message":"Route Not Found"}

Is this expected?

@lwasser
Copy link
Member Author

lwasser commented Mar 4, 2025

@pllim yes - it's a circle CI think i figured out how to fix it - you have to force relative paths. the working path is this:

https://output.circle-artifacts.com/output/job/5646506d-b78e-4155-a44d-dd3788affb54/artifacts/0/_site/communities/astropy.html

it's a quirk that is specific to circleCI / CI rendering outputs where you have to tell jekyll to create the path. I haven't gone through the entire site to fix it yet :( but it's only a ci issue the live site will be fine.

@lwasser lwasser merged commit 05b0e63 into pyOpenSci:main Mar 4, 2025
4 checks passed
@lwasser lwasser deleted the astro2 branch March 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants