Fix: peer review landing page

[lwasser]

This is an attempt the make the peer review landing page on our website a bit more user focused with a narrative.
it breaks the page into sections.

Current status:

• This PR is ready to merge text wise and structurally. the redesign i think looks nice. All it needs is graphics. it can remain open until those are done which will likely be before xmas. Or we can opt to add filler graphics and merge it as is for now. which could also be ok. i can just make some basic graphics.

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1206057663441255
  • https://app.asana.com/0/0/1205973778589091
  • https://app.asana.com/0/0/1206075195584338

[willingc]

Editing for content

[willingc]

Unless you are going to use this in the next week or so, I would remove all comments as they clutter the content and can always be resurrected from the repo history.

[lwasser]

great point - i'll do that now!!

[willingc]

remove

[willingc]

Suggested change

// padding: 32px 24px;

[willingc]

Remove the block 😄

[lwasser]

@willingc 😆 you have caught me in my usual pattern of being nervous to sometimes delete things so i comment it out until i'm sure i want to really delete it! i'll go through and cleanup comments. this was me removing the circles on our people cards but i think i want to keep them for other content cards . so i'll make that fix locally!!

[willingc]

Looking good Leah. Most are small content tweaks.

[lwasser]

to view the rendered page you can go here

in the artifacts section of our circleci build!! i will swap out images with more fitting graphics once we have stable content . right now i just used the same image over and over as a placeholder.

[willingc]

It looks great @lwasser. ☀️

[willingc]

Looking good.

[lwasser]

thank you so much @willingc will be making and integrating all of these changes in the next day.

[lwasser]

the related fix to the author page in our peer review guide here

the idea being that an author hits the peer review page and then can be directed to the author guide in the "Ready to submit" section. That guide page then has relevant sections of the guide for them to review creating an author content pathway.

[willingc]

CI is passing. I'm going to approve. @lwasser 🚢 it.

[kierisi]

added some copy suggestions!

[kierisi]

Suggested change

	win-win!
	excerpt: "Our collaboration with JOSS means that you don't have to chose between pyOpenSci and JOSS. Submit your package to pyOS for review, and if your package is accepted and in scope for JOSS, it will be fast-tracked through JOSS' review process; they will only review your `paper.md` file. It's a win-win!"

[lwasser]

i want to commit this one but i suspect this edit needs to be applied to lines 38-42 and here it's replacing just line 42 with that entire blog of text. i'll come back to this edit !! the text is excellent!

[willingc]

Awesome @kierisi. Love the alt text additions. @lwasser I will let you rereview content and it looks good to me.

[lwasser]

ok updates!
✅ i've merged all of your input here @kierisi thank you so much for all of the content edits. I welcome a second round if you wish to look at things again
✅ i've cleaned up the styles for the page - specifically the text and block at the bottom was too wide to be readable.

what's left

• new images for the page that align with our colors and "playful" style
• alt tags for those images

The current rendered page can be seen here

@kierisi please in working on this page i realized the JOSS section had been removed so i added it back.
I also think we could have images that are a bit less square to balance the page out some.

i'm going to open a separate PR to update our partners page. @kierisi i suspect you'll have really good feedback for that page as well. it's a similar style but also needs some cleanup of messaging and brand. i might be able to create better diagrams now that i'm using canva more but it still has some AI generated images of people (we do want representations of people all over!!)

[willingc]

@lwasser @kierisi May I make a small suggestion about PRs...

When making changes that are fluid (I.e. text, images, styling), it's often easier to create multiple PRs instead of combining into one PR.

I typically ask myself:

• Is this one change better than what is already there?
• Can this change stand alone without other changes?
• Is there any significant downside to one PR landing a day or two before the next PR? (I use the Issues to keep track of to do items.)

For example, I would recommend landing all of the content changes in this PR, create another PR for the images, and another for the styling.

[willingc]

Small typo and clarifying text. 🚢

[lwasser]

@lwasser @kierisi May I make a small suggestion about PRs...

When making changes that are fluid (I.e. text, images, styling), it's often easier to create multiple PRs instead of combining into one PR.

I typically ask myself:

• Is this one change better than what is already there?
• Can this change stand alone without other changes?
• Is there any significant downside to one PR landing a day or two before the next PR? (I use the Issues to keep track of to do items.)

For example, I would recommend landing all of the content changes in this PR, create another PR for the images, and another for the styling.

Thank you @willingc this is helpful. i will definitely think about this more carefully for future pr's. In this case when i went to edit the page there was a lot of inline HTML with styles applied there that made the content more difficult to review.

so i pulled that html out and tried to move all of the text to the front matter for simplified editing and then templated content via includes and styles that could be resused. it was easier for me to do this all at once but i can see how as a reviewer it would make for a more complex review. i'll think about how to parse those elements out separately in the future. it's just a bit tricky when some of these pages were created a bit haphazardly (by me!)

we have asana tasks locally to track updates to images. But we can't edit alt tags on the page until images are fixed. i'm open to suggestions that you have about how to chunk the work buckets out a bit more cleanly as well.

[willingc]

Let's land this PR 😄

[willingc]

@lwasser Looks like there is a merge conflict here.

[lwasser]

ok! the only downside of merging it now is there is one image i used 3-4 times on the page.

but i suppose we could just embrace a second pr that updates those images knowing not that many people will be on the page nor will they judge us for using an image several times? but i'll go ahead and merge and might just put other placeholder images in via a later pr (from the partners page) .