Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use english symbols #2451

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DanyloTrofymov
Copy link

Notes:

  • When the layout is English, everything works as it is. When it's another language then it is a bit slower.
  • Probably it would be better to add an array of Latin languages and check if current_language in latin_languages
  • If XKeyboard is not initialized then the program just skips changing layout step

@DanyloTrofymov
Copy link
Author

I've run ruff check --fix locally before pushing and everything passed the checks. Could you suggest me something? pre-commit not works for me

@pfps
Copy link
Collaborator

pfps commented Apr 23, 2024

I suspect that your are running ruff with different options than those for the Solaar style. Either that or you are not incorporating the changes that ruff made.

If everything is set up correctly git should be running the ruff checks as part of its pre-commit hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants