Update for latest dsdk #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
requested changes
Jun 12, 2022
| "tomer = curator.make_tome(\n", | ||
| " 'footsteps_by_rank',\n", | ||
| " footsteps_tome_name,\n", | ||
| " header_tome_name=os.environ.get(\"PURESKILLGG_TOME_DEFAULT_HEADER_NAME\"),\n", |
There was a problem hiding this comment.
Why did we need to add this line? Doesn't it use that env var automatically?
There was a problem hiding this comment.
bug introduced when i made the copier its own class. Fix is here, just gotta upgrade dsdk version. pureskillgg/dsdk@9907100
There was a problem hiding this comment.
Fixed in latest DSDK
Co-authored-by: Evan Sosenko <[email protected]>
Co-authored-by: Evan Sosenko <[email protected]>
razor-x
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.