Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find packages that will be dropped from the package set #266

Conversation

maxdeviant
Copy link
Contributor

@maxdeviant maxdeviant commented Nov 8, 2021

As described in #250, this PR adds a script to find packages that will be dropped from the package set.

The script will output a report of the packages that will be dropped, as well the reason for them being dropped.

@maxdeviant maxdeviant marked this pull request as ready for review November 9, 2021 02:35
@maxdeviant
Copy link
Contributor Author

This is the current output of the script:

aff-bus v5.0.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

errors v4.1.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

foreign-generic v11.0.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

free v6.1.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

geometry-plane v1.0.1 will be dropped from the package set due to:
	missing license

gl-matrix v2.0.1 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

grid-reactors v2.1.0 will be dropped from the package set due to:
	bad dependency versions:
		Dependency: canvas-action
		Failed bounds: artemisSystem/purescript-canvas-action#43de19ee369d1ff9fe7eff1e583b828809fd9e36

homogeneous v0.3.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

node-he v0.2.0 will be dropped from the package set due to:
	bad dependency versions:
		Dependency: test-unit
		Failed bounds: justinwoo/purescript-test-unit#compiler/0.12

node-sqlite3 v6.0.0 will be dropped from the package set due to:
	bad dependency versions:
		Dependency: test-unit
		Failed bounds: justinwoo/purescript-test-unit#compiler/0.12
		Dependency: node-fs-aff
		Failed bounds: justinwoo/purescript-node-fs-aff#compiler/0.12
		Dependency: simple-json
		Failed bounds: #compiler/0.12

parsing v7.0.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

parsing-dataview v2.0.1 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

parsing-repetition v0.0.6 will be dropped from the package set due to:
	bad dependency versions:
		Dependency: parsing-expect
		Failed bounds: markfarrell/purescript-parsing-expect

prettier v0.3.0 will be dropped from the package set due to:
	bad dependency versions:
		Dependency: spec
		Failed bounds: justinwoo/purescript-spec#compiler/0.12

ps-cst v1.2.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

supply v0.1.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

typelevel-lists v2.0.1 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

unicode v5.0.0 will be dropped from the package set due to:
	bad license:
		Invalid SPDX identifier: NOASSERTION
		Did you mean BSD-Protection?

@maxdeviant maxdeviant changed the title WIP: Find packages that will be dropped from the package set Find packages that will be dropped from the package set Nov 9, 2021
Before running this script you will need to have a `bower-exclusions.json` file (from running the [Legacy Import](#legacy-import)) and a `package-set-packages.json` file:

```console
$ wget https://raw.githubusercontent.com/purescript/package-sets/master/packages.json -O package-set-packages.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed simpler to make downloading this a manual step than making it part of the script. I can move it into the script itself, if desired.

@@ -0,0 +1,141 @@
module Registry.Scripts.FindDroppedPackages where
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FindDroppedPackages isn't a perfect name, but FindPackagesThatWillBeDropped seemed a tad wordy.

@thomashoneyman
Copy link
Member

👋 Hey @maxdeviant! Thanks so much for putting this script together -- it was really useful to see how the package sets were going to be affected. However, as we're not going to need this script going forward I opted to close this PR rather than merge to master. We learned what we needed to learn. Just wanted to acknowledge your work and explain a little why this got closed. Thanks!

@maxdeviant
Copy link
Contributor Author

👋 Hey @maxdeviant! Thanks so much for putting this script together -- it was really useful to see how the package sets were going to be affected. However, as we're not going to need this script going forward I opted to close this PR rather than merge to master. We learned what we needed to learn. Just wanted to acknowledge your work and explain a little why this got closed. Thanks!

Thanks Thomas!

The script served its purpose and now can be put out to Git pasture 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants