-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find packages that will be dropped from the package set #266
Find packages that will be dropped from the package set #266
Conversation
This is the current output of the script:
|
Before running this script you will need to have a `bower-exclusions.json` file (from running the [Legacy Import](#legacy-import)) and a `package-set-packages.json` file: | ||
|
||
```console | ||
$ wget https://raw.githubusercontent.com/purescript/package-sets/master/packages.json -O package-set-packages.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed simpler to make downloading this a manual step than making it part of the script. I can move it into the script itself, if desired.
@@ -0,0 +1,141 @@ | |||
module Registry.Scripts.FindDroppedPackages where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FindDroppedPackages
isn't a perfect name, but FindPackagesThatWillBeDropped
seemed a tad wordy.
👋 Hey @maxdeviant! Thanks so much for putting this script together -- it was really useful to see how the package sets were going to be affected. However, as we're not going to need this script going forward I opted to close this PR rather than merge to master. We learned what we needed to learn. Just wanted to acknowledge your work and explain a little why this got closed. Thanks! |
Thanks Thomas! The script served its purpose and now can be put out to Git pasture 😄 |
As described in #250, this PR adds a script to find packages that will be dropped from the package set.
The script will output a report of the packages that will be dropped, as well the reason for them being dropped.