Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore generic, eq, ord, and show instances #17

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

jvliwanag
Copy link
Member

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jvliwanag jvliwanag requested a review from srghma October 23, 2020 04:21
@srghma
Copy link
Collaborator

srghma commented Oct 23, 2020

You should run sync-cst-declaration-to-smart-cst.sh

@srghma
Copy link
Collaborator

srghma commented Oct 23, 2020

And here is how to fix tests purescript-spec/purescript-spec#109 (comment)

@jvliwanag
Copy link
Member Author

@srghma looks like the error on the build is caused by the override of purescript-either from packages.dhall. In particular, Data.String.Regex.Unsafe and Test.Spec.Reporter.Tap depend on the original fromLeft/fromRight definitions.

Removing that override fixes the build for me. Would it be alright to remove the override?

@srghma
Copy link
Collaborator

srghma commented Oct 23, 2020

yes, we can do this too, I hope we don't use import Either ((\/))

@srghma srghma merged commit 7411810 into purescript-codegen:master Oct 23, 2020
@srghma
Copy link
Collaborator

srghma commented Oct 23, 2020

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants