Add PuppetCore gem source support to gem_ci and tools_mend_ruby workflows #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is about puppetcore enablement:
module_ci.yml
, removing an unnecessary input parameter.gem_ci.yml
andtooling_mend_ruby.yml
enabling puppetcore.All updates have been manually tested against puppetcore and non-puppetcore consumers to ensure backward compatibility. For example, this puppet_upgrade PR enables puppetcore and re-uses both the
gem_ci.yml
andtooling_mend_ruby.yml
. Therefore I found 2 non-puppetcore consumers (puppet-strings and puppet_litmus) of these same shared workflows and verified that these consumers also continue to work as expected. The tests results are all below in the PR comments.Changes
puppetcore_api_type
input parameter because the extra flexibility was not worth the cost of added complexity, I believe.PUPPET_FORGE_TOKEN
. This "secret" is then in turn used to set theBUNDLE_RUBYGEMS___PUPPETCORE__PUPPET__COM
which enables authenticated access to the puppetcore gemsALSO updated the how to document for consumers of these re-usable modules, see
docs/how-to/how_to_inject_puppetcore_authentication_into_the_shared_workflows.md
Impact
PUPPET_FORGE_TOKEN
secret on their repository