-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions w/esc tutorial #14619
base: master
Are you sure you want to change the base?
Conversation
Your site preview for commit eb9b83b is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14619-eb9b83bc.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 5f3737f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14619-5f3737f9.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 19b7e24 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14619-19b7e24f.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 3dbaba9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14619-3dbaba9d.s3-website.us-west-2.amazonaws.com. |
{{< figure src="esc-add-env.png" caption="Figure: Pulumi ESC add environment">}} | ||
|
||
{{% notes type="warning" %}} | ||
Replace the roleArn value with the ARN of your AWS IAM role configured for Pulumi Cloud OIDC access. See the [configuring OIDC guide](/docs/pulumi-cloud/access-management/oidc/provider/aws/ for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a closing parenthesis on the markdown link
``` | ||
|
||
{{% notes type="info" %}} | ||
Replace <your-org>/<your-esc-env> with the name of your Pulumi ESC environment, and update stack-name values with your organization, project, and stack replacing stack-name: <your-org>/<stack-project>/<stack>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the <your-org>/<your-esc-env>
just showing up as a /
. Also <your-org>/<stack-project>/<stack>
is //
. Maybe not escaped properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once other reviewer's feedback is applied, this LGTM. Rubber stamping.
New ESC blog covering Github Actions w/ESC:
Fixes: #13974