-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak wording for the "Manual download" info on the download page #278
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9a45ea8
Tweak wording for the "Manual download" info on the download page
DeeDeeG cff15da
download: Apply suggested revision from Daeraxa during PR review
DeeDeeG 085be22
Bigger revamp of the "Manual Download" instructions
DeeDeeG 7d1ef96
download: Apply another review suggestion from Daeraxa
DeeDeeG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -190,28 +190,32 @@ You can bypass this by clicking "More info" then "Run anyway". | |||||||||
## Manual download | ||||||||||
|
||||||||||
Binaries are built from a number of different branches and PRs but you should | ||||||||||
stick to the **master** branch releases for the most stable ones unless you know | ||||||||||
stick to the **`master`** branch releases for the most stable ones unless you know | ||||||||||
exactly what you are looking for. | ||||||||||
|
||||||||||
We currently build on both GitHub Actions and Cirrus CI: | ||||||||||
|
||||||||||
- GitHub Actions is used for building the majority of our binaries and builds | ||||||||||
are run on every commit or PR. | ||||||||||
- Direct artifact download is available only for those with at least read | ||||||||||
permission on the repository. All artifacts are therefore automatically | ||||||||||
uploaded to the [pulsar-edit/pulsar-rolling-releases](https://github.com/pulsar-edit/pulsar-rolling-releases/releases) | ||||||||||
- Direct artifact download is available only for those who are logged in | ||||||||||
with their GitHub accounts. All artifacts from the `master` branch | ||||||||||
are therefore automatically uploaded to the [pulsar-edit/pulsar-rolling-releases](https://github.com/pulsar-edit/pulsar-rolling-releases/releases) | ||||||||||
repository for access by anyone. | ||||||||||
- Cirrus CI is _only_ used for building Apple silicon (macOS M1/M2) and ARM | ||||||||||
Linux binaries. These are run less frequently (every Monday, Wednesday, and Friday). | ||||||||||
|
||||||||||
To download a binary produced by GitHub Actions then follow the below steps: | ||||||||||
To download a binary produced by GitHub Actions, follow the below steps: | ||||||||||
|
||||||||||
- Navigate to the [pulsar-edit/pulsar-rolling-releases](https://github.com/pulsar-edit/pulsar-rolling-releases/releases) | ||||||||||
releases. | ||||||||||
- Select the most recent release (or for a specific release reference the timestamp | ||||||||||
part of the version e.g. 1.109.**2023091606**). | ||||||||||
- Most binaries will be available with every release but Apple silicon and | ||||||||||
ARM Linux binaries will not. You may need to look for earlier releases. | ||||||||||
- x86_64 binaries will be grouped together for most releases, | ||||||||||
but occasionally they will be split across multiple releases. | ||||||||||
Apple silicon and ARM Linux binaries are usually grouped together | ||||||||||
in their own separate release from the x64 binaries, but sometimes not. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
You may need to look through the earlier releases | ||||||||||
to find binaries for your platform. | ||||||||||
- Choose the binary you wish to download from the `Assets` section (you may need | ||||||||||
click the `Show all x assets` link to display them all). See below for | ||||||||||
descriptions of all available binaries. | ||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably remove the strong from this as I think converting it to inline code is enough to differentiate it.