Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertion message handling in pytest cover command #218

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

azewiusz
Copy link
Contributor

This is suggested solution to #217

@pschanely
Copy link
Owner

For reasons that would not at all be obvious to you, we need to realize symbolic values inside the on_path_complete callback. I've pushed a commit doing it this way.

You wouldn't have noticed this issue because it only becomes problematic when the exception message is itself symbolic (the unit test I added would fail otherwise).

I think pytest is matching against str() of the exception object also, so I think we should do the same. (though in simple cases I believe this is the same as str(exc.args[0]))

PTAL! Unless you have further suggestions, I'll get this merged into main!

@pschanely pschanely merged commit 6761765 into pschanely:main Oct 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants