Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulley: HomeBack state is never used #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pulley: HomeBack state is never used #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/modules/pulley.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ namespace pulley {

Pulley pulley;

bool __attribute__((noinline)) Pulley::FinishHomingAndPlanMoveToParkPos() {
mm::motion.SetPosition(mm::Pulley, 0);
return true;
}

bool Pulley::Step() {
if (IsOnHold()) {
return true; // just wait, do nothing!
Expand All @@ -28,10 +23,6 @@ bool Pulley::Step() {
case Moving:
PerformMove();
return false;
case HomeBack:
homingValid = true;
FinishHomingAndPlanMoveToParkPos();
return true;
case Ready:
return true;
case TMCFailed:
Expand Down
2 changes: 1 addition & 1 deletion src/modules/pulley.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class Pulley : public motion::MovableBase {
virtual void PrepareMoveToPlannedSlot() override {}
virtual void PlanHomingMoveForward() override {}
virtual void PlanHomingMoveBack() override {}
virtual bool FinishHomingAndPlanMoveToParkPos() override;
virtual bool FinishHomingAndPlanMoveToParkPos() override { return true; }
virtual void FinishMove() override {}
};

Expand Down
Loading