Skip to content
This repository was archived by the owner on Jan 2, 2024. It is now read-only.

fix: issues 107 x-form-select not hidding placeholder value #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: issues 107 x-form-select not hidding placeholder value #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d863d3e
fix: issues 107 x-form-select not hidding placeholder value
Oct 26, 2023
4ed25d3
Merge branch 'protonemedia:master' into bugfix-select-placeholder-hid…
DiveshDwivedi Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/bootstrap-4/form-select.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
{!! $attributes->merge(['class' => 'form-control ' . ($hasError($name) ? 'is-invalid' : '')]) !!}>

@if($placeholder)
<option value="" disabled @if($nothingSelected()) selected="selected" @endif>
<option value="" disabled @if($nothingSelected()) selected="selected" @endif @if($hidden) hidden="hidden" @endif>
{{ $placeholder }}
</option>
@endif
Expand All @@ -42,4 +42,4 @@
@if($hasErrorAndShow($name))
<x-form-errors :name="$name" />
@endif
</div>
</div>
2 changes: 1 addition & 1 deletion resources/views/bootstrap-5/form-select.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
>

@if($placeholder)
<option value="" disabled @if($nothingSelected()) selected="selected" @endif>
<option value="" disabled @if($nothingSelected()) selected="selected" @endif @if($hidden) hidden="hidden" @endif>
{{ $placeholder }}
</option>
@endif
Expand Down
3 changes: 3 additions & 0 deletions src/Components/FormSelect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class FormSelect extends Component
public bool $multiple;
public bool $floating;
public string $placeholder;
public string $hidden;

/**
* Create a new component instance.
Expand All @@ -34,13 +35,15 @@ public function __construct(
bool $showErrors = true,
bool $manyRelation = false,
bool $floating = false,
bool $hidden = false,
string $placeholder = ''
) {
$this->name = $name;
$this->label = $label;
$this->options = $options;
$this->manyRelation = $manyRelation;
$this->placeholder = $placeholder;
$this->hidden = $hidden;

if ($this->isNotWired()) {
$inputName = static::convertBracketsToDots(Str::before($name, '[]'));
Expand Down