-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow checking that the DNS configuration is correct #52
Draft
RemiBardon
wants to merge
14
commits into
master
Choose a base branch
from
2024-07-26-dns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiBardon
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Aug 3, 2024
RemiBardon
changed the base branch from
2024-07-25-hotfixes
to
2024-08-03-deploy-on-rpi
August 28, 2024 09:22
RemiBardon
force-pushed
the
2024-07-26-dns
branch
from
August 28, 2024 09:23
eb225c1
to
5c22bb7
Compare
1 task
RemiBardon
force-pushed
the
2024-07-26-dns
branch
from
September 3, 2024 14:22
1a3c17a
to
f073a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_dns_records
)check_dns_records
)Integration tests (network-config.yaml
)check_ports
)Integration tests (network-config.yaml
)check_ip
)Integration tests (network-config.yaml
)check_network_configuration
)Integration tests (network-config.yaml
)Edit: After a discussion regarding Nomad during the review of this PR, we have decided not to write integration tests for those features. There are multiple reasons: