Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the GOOS to CI test #1787

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the GOOS to CI test #1787

wants to merge 2 commits into from

Conversation

khanhtc1202
Copy link

From the KubeCon ContribFest 👋

This PR added GOOS as variable to the go test CI

Fix #1761

Please check @ArthurSens

@khanhtc1202
Add the GOOS to CI test
8fb4dce 
Signed-off-by: khanhtc1202 <[email protected]>
kakkoyun
kakkoyun requested changes Apr 10, 2025
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

However CI fails, so it needs some more work.

@kakkoyun
Copy link
Member

When we are at it maybe we should add GOARCH as well. Now that GitHub actions have the arm64 machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun requested changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens ArthurSens is a code owner

@bwplotka bwplotka Awaiting requested review from bwplotka bwplotka is a code owner

@vesari vesari Awaiting requested review from vesari vesari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI tests that builds/tests client_golang for all supported GOOS
2 participants
@khanhtc1202 @kakkoyun