-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paper: Add code examples and clarify terminology #2719
Conversation
38941b5
to
2b10107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM--- Thanks for all your hard work on this @EwoutH
Thanks for reviewing! @quaquel are you good with the addition of the discrete and continuous terminology? |
Co-authored-by: Jan Kwakkel <[email protected]>
@quaquel thanks, it was a reviewer suggestion but I didn’t think it aligned with ABM terminology, like you confirmed. Thanks for the specific suggestions! |
This PR implements some last feedback from @jofmi and @martibosch on our JOSS paper for Mesa.
Each commit processes one feedback point:
Rendered paper (PDF).
Part of #2666.