Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper: Fix [from Marti] Typos and minor syntactic comments. #2713

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

jackiekazil
Copy link
Member

@jackiekazil jackiekazil commented Mar 11, 2025

Updates for JOSS paper #2666

These are minimal updates from Marti's review.

@jackiekazil jackiekazil changed the title paper: Fix **[from Marti]** Typos and minor syntactic comments. paper: Fix [from Marti] Typos and minor syntactic comments. Mar 11, 2025
@EwoutH EwoutH requested review from EwoutH, quaquel and jofmi March 11, 2025 06:31
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, so far looks good.

Are you planning to make more changes in this PR?

@jackiekazil
Copy link
Member Author

No... going to merge and keep things moving.

@jackiekazil
Copy link
Member Author

@EwoutH before I merge -- do u know where the RTD error came from?

@EwoutH
Copy link
Member

EwoutH commented Mar 12, 2025

The paper isn't included in RTD, so it must be unrelated. Go ahead and merge!

@EwoutH EwoutH merged commit f79438b into paper_2024 Mar 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants