Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series of minor paper updates #2690

Merged
merged 5 commits into from
Feb 15, 2025
Merged

Series of minor paper updates #2690

merged 5 commits into from
Feb 15, 2025

Conversation

jackiekazil
Copy link
Member

@jackiekazil jackiekazil commented Feb 14, 2025 •
edited
Loading

RE: #2666

Fixes

  • l34 What does pure python mean? Does it not also use C, JS/React, etc.? (@jackiekazil)
  • l96 Please add a link or reference regarding the Solara package (@jackiekazil)
  • l143 Maybe say "want" instead of "need"? (@jackiekazil)
  • Citation error, noticed in passing.

@EwoutH EwoutH requested review from jofmi and EwoutH February 14, 2025 10:16
EwoutH
EwoutH approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@EwoutH EwoutH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks!

@jackiekazil jackiekazil merged commit b15528e into paper_2024 Feb 15, 2025
9 of 10 checks passed
@wang-boyu wang-boyu added the docs Release notes label label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutH EwoutH EwoutH approved these changes

@jofmi jofmi jofmi approved these changes

Assignees
No one assigned
Labels
docs Release notes label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackiekazil @EwoutH @jofmi @wang-boyu