Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license text, notice and project team name #252

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

wang-boyu
Copy link
Member

@wang-boyu wang-boyu added ignore-for-release PRs that aren't included in the release notes maintenance Release notes label labels Sep 26, 2024
@wang-boyu wang-boyu requested review from rht and EwoutH September 26, 2024 01:26
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (ce501b6) to head (1048dab).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   78.21%   78.78%   +0.57%     
==========================================
  Files          10        9       -1     
  Lines         693      759      +66     
  Branches      151      171      +20     
==========================================
+ Hits          542      598      +56     
- Misses        127      128       +1     
- Partials       24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for syncing!

NOTICE Outdated
@@ -0,0 +1,13 @@
Copyright 2014-2024 Core Mesa Team and contributors
Copy link
Contributor

@rht rht Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be the start year of when Mesa-Geo was first (edit: prepared for) released, according to https://www.gnu.org/licenses/gpl-howto.html.

The copyright notice should include the year in which you finished preparing the release (so if you finished it in 1998 but didn't post it until 1999, use 1998).

The reason why I cited GPL instead of Apache-2.0, because for the later's how-to guide, the year is specified to be only the latest year. There is an opinion on this: https://opensource.stackexchange.com/questions/2171/refreshing-shared-copyright-dates-in-apache-2-0-licensed-code (not answered by a lawyer).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. I changed 2014 to 2017, same as what we have in docs/conf.py:

copyright = f"2017-{date.today().year}, Project Mesa-Geo Team"

@rht rht merged commit d9477fc into projectmesa:main Sep 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release PRs that aren't included in the release notes maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants