-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update license text, notice and project team name #252
Conversation
wang-boyu
commented
Sep 26, 2024
- update license text and notice to align with Add NOTICE and full copy of Apache 2.0 license text mesa#2318
- change all "Project Mesa-Geo Team" to "Project Mesa Team"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 78.21% 78.78% +0.57%
==========================================
Files 10 9 -1
Lines 693 759 +66
Branches 151 171 +20
==========================================
+ Hits 542 598 +56
- Misses 127 128 +1
- Partials 24 33 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for syncing!
NOTICE
Outdated
@@ -0,0 +1,13 @@ | |||
Copyright 2014-2024 Core Mesa Team and contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be the start year of when Mesa-Geo was first (edit: prepared for) released, according to https://www.gnu.org/licenses/gpl-howto.html.
The copyright notice should include the year in which you finished preparing the release (so if you finished it in 1998 but didn't post it until 1999, use 1998).
The reason why I cited GPL instead of Apache-2.0, because for the later's how-to guide, the year is specified to be only the latest year. There is an opinion on this: https://opensource.stackexchange.com/questions/2171/refreshing-shared-copyright-dates-in-apache-2-0-licensed-code (not answered by a lawyer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh well, Apache devs themselves used a year range: https://github.com/apache/spark/blob/fe1cf3200223c33ed4670bfa5924d5a4053c8ef9/NOTICE#L2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this. I changed 2014 to 2017, same as what we have in docs/conf.py
:
Line 62 in 4e22c5c
copyright = f"2017-{date.today().year}, Project Mesa-Geo Team" |
07563f8
to
1048dab
Compare