Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude response, request data from result #1944

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Exclude response, request data from result #1944

merged 1 commit into from
Jan 27, 2025

Conversation

dogancanbakir
Copy link
Member

Closes #1914

@dogancanbakir dogancanbakir self-assigned this Oct 11, 2024
@dogancanbakir dogancanbakir linked an issue Oct 11, 2024 that may be closed by this pull request
CSV output ignores command line options for what to extract when use '-filter-condition' argument #1914
Open
Mzack9999
Mzack9999 requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using something like github.com/jszwec/csvutil with csv:"body,omitempty"?

@dogancanbakir
Copy link
Member Author

Let's create a follow-up issue to assess this option, as it may involve replacing CSV-related mappings with this package.

Mzack9999
Mzack9999 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up ticket at #1984 - This PR excludes the fields in export, potentially creating missing data if expected

@ehsandeep ehsandeep merged commit ace6864 into dev Jan 27, 2025
11 checks passed
@ehsandeep ehsandeep deleted the fix_csv_output branch January 27, 2025 10:20
@BrewTestBot BrewTestBot mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV output ignores command line options for what to extract when use '-filter-condition' argument
3 participants
@dogancanbakir @ehsandeep @Mzack9999