Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] add redirect counters #9829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomastigera
Copy link
Contributor

Description

[BPF] add redirect counters

[BPF] create entry in counters map when attaching to device/hook

This makes it possible to expand the number of counters beyond what the
ebpf stack can handle. Previously, an empty/zeroed entry was created when
the ebpf program failed to get the counters and we needed to allocate
enough space on stack for the empty value. This hit the wall of the
stack size.

It is easier to create values across all the CPUs at the same time when
the programs are being attached to the hooks. In addition, the all
counters are always valid and at least zero for each device.

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

This makes it possible to expand the number of counters beyond what the
ebpf stack can handle. Previously, an empty/zeroed entry was created when
the ebpf program failed to get the counters and we needed to allocate
enough space on stack for the empty value. This hit the wall of the
stack size.

It is easier to create values across all the CPUs at the same time when
the programs are being attached to the hooks. In addition, the all
counters are always valid and at least zero for each device.
@tomastigera tomastigera requested a review from a team as a code owner February 12, 2025 23:04
@marvin-tigera marvin-tigera added this to the Calico v3.30.0 milestone Feb 12, 2025
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Feb 12, 2025
@tomastigera tomastigera added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact and removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Feb 12, 2025
@tomastigera tomastigera force-pushed the tomas-bpf-redir-counters branch from c5f0d8f to c149cb5 Compare February 14, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants