Replace gogoprotobuf with golang protobuf #8949
Open
+10,081
−23,230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marvin-tigera
added
release-note-required
hjiawei
force-pushed
the
hda2/protoc-update-map-keys
branch
from
19fd5f2
to
b49a82b
Compare
hda2
force-pushed
the
hda2/protoc-update-map-keys
branch
2 times, most recently
from
9bc4afd
to
6d79bc0
Compare
hjiawei
changed the title
hjiawei
reviewed
Jul 5, 2024
hjiawei
reviewed
Jul 5, 2024
hjiawei
reviewed
Jul 5, 2024
hjiawei
reviewed
Jul 5, 2024
hjiawei
reviewed
Jul 5, 2024
hjiawei
reviewed
Jul 5, 2024
hjiawei
reviewed
Jul 5, 2024
hjiawei
force-pushed
the
hda2/protoc-update-map-keys
branch
from
c2d63e5
to
4b649d2
Compare
hjiawei
reviewed
Jul 9, 2024
hjiawei
reviewed
Jul 9, 2024
hjiawei
reviewed
Jul 9, 2024
hjiawei
reviewed
Jul 9, 2024
hjiawei
reviewed
Jul 9, 2024
hjiawei
reviewed
Jul 10, 2024
hjiawei
force-pushed
the
hda2/protoc-update-map-keys
branch
from
5fb90d5
to
cde5c48
Compare
github.com/gogo/protobuf is deprecated [1] so use the official protobuf. [1] https://twitter.com/awalterschulze/status/1584553056100057088
marvin-tigera
added
release-note-required
hjiawei
added
docs-not-required
|
/sem-approve |
|
/sem-approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change replaces gogoprotobuf with golang protobuf for Calico components. Gogoprotobuf is deprecated since Oct 2022 and is not updated. Replacing gogoprotobuf with golang protobuf can bring in new protobuf features/fixes and reduce outdated package dependencies.
To work with golang protobuf, we need (1) a calico/go-build change to include protoc in the toolchain image and (2) workaround an issue that protobuf generated types are not comparable.
Related issues/PRs
Require projectcalico/go-build#574 to be merged and pick to release branches first.
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.