moves next after numbers #3272
Merged
moves next after numbers #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Aug 14, 2024
| -%> | ||
| <% if current_page.first? %> | ||
| <li class="page-item disabled"> | ||
| <%= link_to raw(t 'views.pagination.previous'), '#', :rel => 'prev', :onclick=>'return false;', class: 'btn btn-link text-decoration-none', aria: { label: t('views.pagination.aria.go_to_previous_page') } %> |
There was a problem hiding this comment.
That is what is in the current pagination.
| </li> | ||
| <% else %> | ||
| <li class="page-item"> | ||
| <%= link_to raw(t 'views.pagination.previous'), url, :rel => 'prev', :remote => remote, class: 'btn btn-link text-decoration-none', aria: { label: t('views.pagination.aria.go_to_previous_page') } %> |
There was a problem hiding this comment.
I don't know. This again was in the old code.
| -%> | ||
| <% page_display = number_with_delimiter(page.to_s) %> | ||
|
|
||
| <li class="page-item <%= 'active' if page.current? %>"> |
There was a problem hiding this comment.
Shouldn't this also have aria-current="page" if it's current?
dnoneill
force-pushed
the
blacklight9-pagination
branch
4 times, most recently
from
3129087
to
977d1cf
Compare
dnoneill
changed the title
|
@dnoneill this requires a rebase. |
dnoneill
force-pushed
the
blacklight9-pagination
branch
from
977d1cf
to
b7eab8e
Compare
dnoneill
force-pushed
the
blacklight9-pagination
branch
from
b7eab8e
to
2882d99
Compare
jcoyne
approved these changes
Sep 25, 2024
cbeer
added a commit
that referenced
this pull request
Sep 25, 2024
cbeer
added a commit
that referenced
this pull request
Oct 1, 2024
cbeer
added a commit
that referenced
this pull request
Oct 1, 2024
jcoyne
added a commit
that referenced
this pull request
Oct 8, 2024
Add configuration to opt-in to the new paginator layout. Backports #3272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see the changes by changing
blacklight/lib/blacklight/engine.rb
Line 71 in a8b5a3d
blacklight9