[WIP ]Instascale hypershift e2e #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fiona-Waters
force-pushed
the
instascale-hypershift-e2e
branch
2 times, most recently
from
e668de3 to
709ff3d
Compare
Fiona-Waters
force-pushed
the
instascale-hypershift-e2e
branch
14 times, most recently
from
061975b to
ceb4e78
Compare
Fiona-Waters
force-pushed
the
instascale-hypershift-e2e
branch
from
ceb4e78 to
992837c
Compare
Fiona-Waters
force-pushed
the
instascale-hypershift-e2e
branch
from
992837c to
9adede8
Compare
sutaakar
reviewed
Dec 12, 2023
test/e2e/instascale_nodepool_test.go
Outdated
| Should(WithTransform(AppWrapperState, Equal(mcadv1beta1.AppWrapperStateActive))) | ||
|
|
||
| // look for a node pool with a label key equal to aw name - expect to find it | ||
| test.Eventually(NodePools(test, connection), TestTimeoutLong). |
There was a problem hiding this comment.
Suggested change
| test.Eventually(NodePools(test, connection), TestTimeoutLong). | |
| test.Eventually(NodePools(test, connection), TestTimeoutGpuProvisioning). |
Fiona-Waters
force-pushed
the
instascale-hypershift-e2e
branch
from
241f616 to
9adede8
Compare
Fiona-Waters
force-pushed
the
instascale-hypershift-e2e
branch
from
9adede8 to
0cf73e8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Jira Issue
What changes have been made
An e2e test has been added to test the entire instascale flow on a ROSA Hosted Hypershift Cluster.
Verification steps
Checks