Files are created in tmp dirs and they are cleaned if tests succeed (#1061) #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Could you create a single temporary directory with the three |
progval
reviewed
Apr 12, 2024
src/scripts/limnoria_test.py
Outdated
| if not os.path.exists('test-conf'): | ||
| os.mkdir('test-conf') | ||
| main_temp_dir = TemporaryDirectory() | ||
| print(f"Temporary directory path: {main_temp_dir.name}") |
There was a problem hiding this comment.
Move this to the .detach() case so it's printed at the end (more visible), and only if the directory is kept.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1061, here we use this:
https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory
to handle the creation of temporary directories. The files are not deleted in case there are any test failures, so they can be inspected.