Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libsignal-protocol-c with libomemo-c #2020

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Feb 21, 2025

The library libsignal-protocol-c is not maintained. This commit will replace the dependency libsignal-protocol-c with libomemo-c.

On 2025-02-07 a new version of protobuf-c has been uploaded to Debian. This new version induced a bug for libsignal-protocol-c and libomemo-c:

  • Bug#1095352: libomemo-c: FTBFS [1]
  • Bug#1095353: libsignal-protocol-c: FTBFS [2]

(Thanks to Dino team and Debian Maintainer it's solved)

libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained by the Dino team.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353
[3] https://github.com/dino/libomemo-c
[4] https://github.com/signalapp/libsignal-protocol-c

Note:
Commits squashed and commit message edited by @jubalh.

The library libsignal-protocol-c is not maintained. This commit will
replace the dependency libsignal-protocol-c with libomemo-c.

On 2025-02-07 a new version of protobuf-c has been uploaded to
Debian. This new version induced a bug for libsignal-protocol-c
and libomemo-c:

 * Bug#1095352: libomemo-c: FTBFS [1]
 * Bug#1095353: libsignal-protocol-c: FTBFS [2]

(Thanks to Dino team and Debian Maintainer it's solved)

libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained
by the Dino team.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353
[3] https://github.com/dino/libomemo-c
[4] https://github.com/signalapp/libsignal-protocol-c

Note:
Commits squashed and commit message edited by @jubalh.
@jubalh jubalh added the cleanup label Feb 21, 2025
@jubalh
Copy link
Member Author

jubalh commented Feb 21, 2025

Received those patches via PM and mailinglist from Stefan.

Comments (to Stefan):
I squashed the two commits into 1. If you use 2 commits then the configure change should have been done with the same commit as changing the source files. Since otherwise it wouldn't build ;)
Then the CI changes could be a separate step.

Don't forget that we use present tense in commit messages (Replace not Replaced).

I also added the (quite valuable) info that you added to the email but not to the patch files themselves.

And CI sais no :)

@Neustradamus
Copy link

@jubalh: Nice! :)

Can you help to update libomemo-c to latest XEP-0384 version?

At this time: 0.8.3 (2022-01-18).

Ticket here:

Note: @Ri0n from @psi-im team has done a PR here:

@jubalh
Copy link
Member Author

jubalh commented Mar 12, 2025

@sjaeckel do we want an ifdef or just switch to libomemo-c?

DebXWoody and others added 3 commits March 15, 2025 08:45
Signed-off-by: Steffen Jaeckel <[email protected]>
Let's just hope it never breaks its API and/or ABI.

Signed-off-by: Steffen Jaeckel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants