Fix unable to download item twice #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially related to #1939
|
|
Thanks for your PR! Could you mention 1939 in the commit message as well? Otherwise good to merge :) |
jubalh
approved these changes
Feb 28, 2024
## Summary Partial fix for #1939 > When doing the same in an unencrypted (no e2ee) chat there is no Downloading… message at all but the file is downloaded. Download a file twice with `/url save`, the second download will not print download progress to the window. The cause is `HTTPDownload`'s `silent` variable is not initialized; so, `silent` points to a second-hand stack memory address with old data. `silent` references data, so the `if` statement will fail in **src/tools/http_download.c:206** and download progress will not print to the window. The fix is to initialize `silent` in both encrypted and unencrypted file download scenarios. ## Testing Valgrind: Yes - `/url save` without OMEMO **SUCCESS**: Try three times with the same URL and download status will display every time. - `/url save` with OMEMO **SUCCESS**: Try three times with the same URL and download status will display every time. - `/plugins install https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py` **SUCCESS**: Try once and download progress is hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partial fix for #1939
Download a file twice with
/url save, the second download will not print download progress to the window.The cause is
HTTPDownload'ssilentvariable is not initialized; so,silentpoints to a second-hand stack memory address with old data.silentreferences data, so theifstatement will fail in src/tools/http_download.c:206 and download progress will not print to the window.The fix is to initialize
silentin both encrypted and unencrypted file download scenarios.Testing
Valgrind: Yes
/url savewithout OMEMOSUCCESS: Try three times with the same URL and download status will display every time.
/url savewith OMEMOSUCCESS: Try three times with the same URL and download status will display every time.
/plugins install [https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py](https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py%60)SUCCESS: Try once and download progress is hidden.