-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build libDifferent CI #917
Conversation
I'm not the best person to review github actions, but from what I know about them, this looks good to me. One more change I'd suggest is that we add the compiled library file to |
Yeah I thought about that but then the ci for the pull request previews wouldn't work. As example, you submitted a change and I would like to test that change, then I would need a build with the new binary in Processing to make sure it works. I think the only way would be to allow the binary to be part of the PR |
Oh, I see. You need the compiled binary to be in the PR so the CI testing will work. There's no way for the CI stuff to compile it itself, before running tests? |
Good you ask, I just realized only macOS can export for macOS so maybe it can just be part of the build chain. I was under the impression that libDifferent needed to be included on other platforms too In any case |
OK, good we talked this through and understand how everything will work moving forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This will compile the native thinkdifferent library, needed for macOS computers
Closes #913
This GitHub Action will: