feat: Implemented border when hover #557
Conversation
✅ Deploy Preview for java-processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Added spacing between each content items in the listUpdated Screenshot for #508 20240826180247.mp4 |
package.json
Outdated
| @@ -71,6 +71,7 @@ | |||
| "react-dom": "^17.0.2", | |||
| "react-helmet": "^6.1.0", | |||
| "react-intl": "^5.25.1", | |||
| "react-refresh": "^0.14.2", | |||
There was a problem hiding this comment.
When I ran the application it showed this -
**ERROR in polyfill
Module not found: Error: Cannot find module 'react-refresh'
that's why i installed that dependency.
There was a problem hiding this comment.
Can you suggest what can be done ?
There was a problem hiding this comment.
I can't replicate that issue, what's your browser/system/node version etc...?
There was a problem hiding this comment.
browser - chrome
system - windows 11
node - v19.6.1
|
Also @SableRaf lmk if the visual changes are approved, especially regarding the spacing and fontsize changes |
|
Thanks @Stefterv! Yes it looks good to me visually. |
src/components/Sidebar.module.css
Outdated
| &::before { | ||
| content: ''; | ||
| position: absolute; | ||
| left: 0; | ||
| top: 50%; | ||
| height: calc(100% - 20%); | ||
| width: 4px; | ||
| background-color: transparent; | ||
| transition: background-color 0.3s; | ||
| transform: translateY(-50%); |
There was a problem hiding this comment.
This entire section is not used
|
Hey @rishabdev2997! Just checking in—are you still interested in finishing up this PR? Let me know; otherwise, I'll go ahead and close it. Thanks! |
|
@SableRaf I will finish it in 3 days. sorry for late reply |
|
Sure thing! No worries. Thanks for your reply :) let us know if you need any support. |
|
I will make a new pr with the updates |
feat: Highlight or add left border to active navbar subitem
#487 - added the feature.
In the issue the problem was not mentioned properly(the download nav item gets a left border for distinction. The same can apply to nav sub-items.) but it seems it indicates navs under the "Table of Contents" section must display the same left border upon selection.
How to see the changes
Here is the Screenshot
20240826172905.mp4