fixed no_tint issue while rendering #7695
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Framebuffer Rendering Issue After
noTint()
CallResolves #7677
Summary of Changes
This PR fixes a bug where calling
noTint()
before rendering a framebuffer would cause an error and prevent correct rendering. The fix ensures thatnoTint()
correctly updates shader uniforms without breaking the framebuffer rendering pipeline.Key Fixes:
noTint()
by setting its default value to[255, 255, 255, 255]
(white) instead ofnull
.Bug Description
When calling
noTint()
before rendering a framebuffer, the following error was thrown:Uncaught TypeError: Cannot read properties of null (reading 'slice')
This happened due to how
noTint()
was modifying the tint uniform value, causing the shader pipeline to fail when rendering framebuffers.Root Cause:
noTint()
was setting the tint value tonull
.null
value, resulting in an error.Fix Implementation
The following changes were made to resolve the issue:
Updated
noTint()
Implementationtint
tonull
, it now defaults to[255, 255, 255, 255]
(white).Testing & Verification
Manual Testing
noTint()
no longer causes framebuffer rendering to fail.Automated Testing
noTint()
is applied before rendering framebuffers.PR Checklist
npm run lint
passes