Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #3274 #3341

Conversation

Harshit-7373
Copy link
Contributor

Solved the issue #3274 the t&c portion of the signup page isn't translated correctly #3274
Fixes #3274

Changes:

    1. I have added and updated the "Warning" line in the translation.json files for all respective languages.
      2.Secondly , I have found that some issues are happening because of the lower version of codemirror thats why i updated it.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Solved the issue processing#3274  the t&c portion of the signup page isn't translated correctly processing#3274

1. I have added and updated the "Warning" line in the translation.json files for all respective languages.
@raclim
Copy link
Collaborator

raclim commented Feb 11, 2025

Thanks for giving this a shot and for dedicating your efforts into looking into this! Although this does resolve some of the original issue, there's a few other ones that are popping up here that I'll run through below.

I'm sorry for not mentioning this directly within the linked issue, but we do already have a pull request that addresses the missing translations, #3275. Ideally, we do not want to rely solely on machine translations, and ensure that we have native speakers confirm that the translations are correct. Since that pull request came in first, I think it's best to continue working off of it.

We also want to make sure that each pull request is as isolated as possible and only handles one issue. Although this does pinpoint some issues that we currently have with CodeMirror v5, we ideally want to handle that in a separate pull request. There has been an open issue for upgrading CodeMirror v5 -> v6, which we are currently working on as it's a major transition.

When submitting a pull request, we also strongly encourage contributors to go through the checklist attached to ensure that there are no linting or testing errors and provide as much explanation and images as possible to ensure that the pull request is ready to merge.

Since we do have an open PR for this, I think we might want to stick with that but please feel free to add any input there. I'm sorry that we couldn't get this in, but I think other ways to also make progress on this issue could be to think of ways to set up a system that could make it easier for native speakers to vet translations. If you also have any suggestions on how to organize issues or ways to help communicate the status of them easier, please feel free to provide them as well!

@raclim raclim closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the t&c portion of the signup page isn't translated correctly
2 participants