Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Page Redesign #3322

Merged
merged 21 commits into from
Jan 17, 2025
Merged

About Page Redesign #3322

merged 21 commits into from
Jan 17, 2025

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Jan 17, 2025

Fixes #2701

Notes:

Changes:

  • Converts the original About page modal into a full size page. The portions pertaining to the modal are removed from IDEView.jsx and IDEOverlays.jsx.
  • Creates a new page module: client/modules/About. This module holds About.jsx and relevant styling/statics (aboutData.js,About.styles.js). routes.jsx is also updated to account for this change.
  • Updates translations/locales/en-US/translations.json with the new page content. Translations in other languages will need to be added.
  • Implements styled-components and removes SASS (_about.scss, main.scss).
  • Removes About.stories.jsx. This will probably need to be reimplemented.

Images:

  • Desktop
Screenshot 2025-01-17 at 5 21 20 PM
  • 770px and above
Screenshot 2025-01-17 at 5 21 28 PM
  • 769px and below. Similar to Mobile, which is illustrated in linked Figma Design.
Screenshot 2025-01-17 at 5 21 42 PM

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim merged commit a5959bd into develop Jan 17, 2025
3 checks passed
Copy link

release-com bot commented Jan 17, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-0904d4752d

@raclim raclim deleted the about-redesign branch January 17, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Megathread: issues with "About" modal responsive design
1 participant