Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination code added #2969

Closed
wants to merge 6 commits into from
Closed

Conversation

DrizzyOVO
Copy link

@DrizzyOVO DrizzyOVO commented Jan 27, 2024

Fixes #2952

Changes: Added pagination to the sketches section.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
p5.js.Web.Editor._.Pagination_pc.mp4
p5.js.Web.Editor._.Pagination_mobile.mp4

Copy link

release-com bot commented Jan 27, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-37b8332765

@DrizzyOVO
Copy link
Author

@lindapaiste @raclim I apologize for closing the pull request I was facing some issues. Hope you guys review it. Thank you.

@raclim
Copy link
Collaborator

raclim commented Mar 4, 2025

Thanks so much for your work on this, I'm sorry that it took a while to get here!

After giving it some thought, although we do want to implement pagination and it does work in the videos you've linked, I think the current setup follows client-side pagination. Ideally, I think we'd want to implement it on the server-side rather than the client to make loading and viewing the sketch list easier for users who have a large amount of sketches. In order to do that, I think that might require having the sorting and filtering happen on the server-side as well, which heavily changes the scale of this feature and might require some more research and changes to the design.

Since this is quite different from what we might want this feature to look like, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to revisit this issue and provide any thoughts if anything comes up!

@raclim raclim closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing Pagination while rendering examples
2 participants