Ensure counter content is exposed to screen reader users #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5b0283 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
khiga8
commented
Jan 16, 2025
| @@ -9,8 +9,8 @@ | |||
| <% if trailing_visual %> | |||
| <span class="Button-visual Button-trailingVisual"> | |||
| <% if @trailing_visual_counter %> | |||
| <span class="d-flex" aria-hidden="true"><%= trailing_visual %></span> | |||
There was a problem hiding this comment.
Setting flex on this newly added span to ensure content remains centered.
There was a problem hiding this comment.
No visual regression - good sign!
10 tasks
khiga8
commented
Jan 16, 2025
| - button "Button ( )": Button () | ||
| - button "Button ( )": Button () | ||
| - button "Button ( )": Button () | ||
| - button "Button ( 15 )" |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Just merged in the latest from |
This comment was marked as outdated.
This comment was marked as outdated.
Apply flex so nested span is centered Temp
hectahertz
approved these changes
Jan 20, 2025
| - button "Button ( )": Button () | ||
| - button "Button ( )": Button () | ||
| - button "Button ( )": Button () | ||
| - button "Button ( 15 )" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR ensures the counter content is exposed to screen reader users.
Before accessible name -
comment ()After accessible name -
comment (15)This removes the
aria-hiddenattribute from the counter component and setssr-onlyoraria-hidden: truedirectly on respective counters in the view file. We want to render one span visually for sighted users (without parenthesis), and one span for screen reader users (with parenthesis to help the announcement).This unintentional bug was introduced in #2807 😓 .
Screenshots
Integration
List the issues that this change affects.
https://github.com/github/accessibility-audits/issues/10088
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.