Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Change @import to @use sass feature #2790

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Feb 5, 2025

Part of #2781

What are you trying to accomplish?

Sass is deprecating @import https://sass-lang.com/documentation/breaking-changes/import/

This PR changes @import calls to @use or @forward based on use.

What approach did you choose and why?

Manually migrated

What should reviewers focus on?

I'll need to integrate test this change

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 21d1a2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan changed the base branch from main to remove_pvc_imports February 5, 2025 00:18
Base automatically changed from remove_pvc_imports to main February 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant