Performance (datatable): limiting re-render for only radiobutton/checkbox cells at row selection #7425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odyCell should re-render.
…y avoiding unnecessary re-render of cells. CAREFUL: some bugs detected related to MetaKey which are still not yet fixed.
…and getNestedValue from BodyCell.js to ObjectUtils and ran prettier to avoid pull request errors
… are only created once. Wrapped several of them in useCallback.
…a RadioCheckCell. The latter is used for the checkbox and radio buttons. This is to avoid re-rendering all cells when a row is selected. Now, only the RadioCheckCell is re-rendered.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
acc-cassio
changed the title
melloware
added
the
Type: Performance
melloware
added
the
Status: Pending Review
|
another good one! I assigned PrimeTek to review |
…ns of BodyCell.js from usecallback - they would get re-created anyway since they depend on functions.
|
global search typing is slow on record with 5k rows. Is this any primereact issues |
|
Is there a chance to implement these modifications in version 10.9.2? |
|
@mertsincan can you make any statement to this and the other performance PR? |
|
@vasubansal333, @rafalwojdowski, @sja-cslab If you need assistance implementing these modifications into your project until the PR is accepted or with other performance improvements, you can contact me by e-mail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #2979.
Main change was the split of the BodyCell into two separate components: one for the Radio buttons and Checkboxes, and another for the rest of the cells. In this way, it is now possible to define different dependencies for them in React.memo, which create a performance gain when selecting row -> only the radio buttons/checkboxes cells are now re-rendered.
This is quite significant mainly when making a "select all rows" operation with a large dataset.
Also some smaller performance improvements by taking out parameters and functions of the BodyCells and placing in the BodyRow and wrapping them in useCallback.
There is still room for performance improvements in future contributions by implementing priority loading and meaningful prop comparison for BodyRow component. Sorting/Filtering operations are still quite inneficient and should also be worked on in the future (will try to do it in the next weeks/months).