Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#17033): tooltip render and alignment issues in scrolltop #17792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbui17
Copy link

@tbui17 tbui17 commented Feb 28, 2025

fixes #17033

The issue stems from inconsistent designation of the target element for offset calculations in alignment. User should now be able to use the directive as expected like so:

<div style="width: 250px; height: 200px; overflow: auto">
      <p>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Vitae et leo duis ut diam. Ultricies mi quis hendrerit dolor magna eget est lorem. Amet consectetur adipiscing
          elit ut. Nam libero justo laoreet sit amet. Pharetra massa massa ultricies mi quis hendrerit dolor magna. Est ultricies integer quis auctor elit sed vulputate. Consequat ac felis donec et. Tellus orci ac auctor augue mauris. Semper
          feugiat nibh sed pulvinar proin gravida hendrerit lectus a. Tincidunt arcu non sodales neque sodales. Metus aliquam eleifend mi in nulla posuere sollicitudin aliquam ultrices. Sodales ut etiam sit amet nisl purus. Cursus sit amet
          dictum sit amet. Tristique senectus et netus et malesuada fames ac turpis egestas. Et tortor consequat id porta nibh venenatis cras sed. Diam maecenas ultricies mi eget mauris. Eget egestas purus viverra accumsan in nisl nisi.
          Suscipit adipiscing bibendum est ultricies integer. Mattis aliquam faucibus purus in massa tempor nec.
      </p>
      <p-scrollTop target="parent" [threshold]="100" pTooltip="bottom" tooltipPosition="bottom" />
</div>

Changes

  • align{direction} and getHostOffset methods all consistently use activeElement

Remarks

Defect Fixes

When submitting a PR, please also create an issue documenting the error and manually link to an issue.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

Copy link

vercel bot commented Feb 28, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@tbui17 tbui17 force-pushed the fix-tooltip-alignment branch from 103131e to cebceed Compare February 28, 2025 23:28
@tbui17 tbui17 force-pushed the fix-tooltip-alignment branch from cebceed to f9a4848 Compare March 1, 2025 05:11
@tbui17 tbui17 marked this pull request as ready for review March 1, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v18 ScrollTop: Unable to add a tooltip to ScrollTop
1 participant