Document BDHC util #363
Open
Document BDHC util #363
+221
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documents the `bdhc_util.c` file, which mainly contains the function used to calculated an object's height based on its 2D position and the BDHC of the map its currently on. Signed-off-by: Kuruyia <[email protected]>
|
Still not sure about the |
lhearachel
reviewed
Feb 6, 2025
|
|
||
| #include "overlay005/bdhc.h" | ||
|
|
||
| BOOL BDHCUtil_CalculateObjectHeight(const fx32 objectY, const fx32 objectX, const fx32 objectZ, const BDHC *bdhc, fx32 *newObjectY); |
There was a problem hiding this comment.
suggestion: I'm definitely more in favor of objectHeight or objectH for clarity.
| @@ -0,0 +1,11 @@ | |||
| #ifndef POKEPLATINUM_BDHC_UTIL_H | |||
There was a problem hiding this comment.
question: Given how small this is, how would we feel combining this with bdhc_loader?
Comment on lines
+91
to
+93
| stripLowerBound = strips[mid].lowerBound; | ||
|
|
||
| if (stripLowerBound > targetLowerBound) { |
There was a problem hiding this comment.
question: Does this match as:
Suggested change
| stripLowerBound = strips[mid].lowerBound; | |
| if (stripLowerBound > targetLowerBound) { | |
| if (strips[mid].lowerBound > targetLowerBound) { |
after removing the stripLowerBound declaration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the
bdhc_util.cfile, which mainly contains the function used to calculated an object's height based on its 2D position and the BDHC of the map its currently on.