Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Thrift migration for TaskStatus #24752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Thrift migration for TaskStatus #24752

wants to merge 1 commit into from
+8,937 −79

Conversation

shangm2
Copy link
Contributor

@shangm2 shangm2 commented Mar 19, 2025 •
edited
Loading

Description

  1. Migrate TaskStatus to IDL-based thrift. Thanks to @NikhilCollooru for suggestion on coding style.
  2. This also includes many thrift struct for upcoming TaskUpdateRequest and TaskInfo thrift migration

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

Sorry, something went wrong.

@shangm2 shangm2 requested a review from a team as a code owner March 19, 2025 01:37
@shangm2 shangm2 requested a review from jaystarshot March 19, 2025 01:37
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Mar 19, 2025
@facebook-github-bot
Copy link
Collaborator

@vhsu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shangm2 shangm2 force-pushed the task_status_thrift branch 2 times, most recently from 2b0feed to ee16523 Compare March 25, 2025 18:17
@facebook-github-bot
Copy link
Collaborator

@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shangm2
Thrift migration for TaskStatus
Loading
Loading status checks…
db26ced
@shangm2 shangm2 force-pushed the task_status_thrift branch from ee16523 to db26ced Compare March 26, 2025 20:16
@shangm2 shangm2 requested a review from elharo as a code owner March 26, 2025 20:16
@facebook-github-bot
Copy link
Collaborator

@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shangm2 shangm2 mentioned this pull request Mar 26, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaystarshot jaystarshot

@elharo elharo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
from:Meta PR from Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shangm2 @facebook-github-bot @prestodb-ci