Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iceberg] Reduce redundant getTable calls in IcebergHiveMetadata #24376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imjalpreet
Copy link
Member

@imjalpreet imjalpreet commented Jan 16, 2025

Description

After #24326, redundant metastore calls can lead to significant performance degradation.

This PR introduces a per-query caching mechanism for Hive table objects in the IcebergHiveMetadata class to improve performance by reducing repeated calls to the metastore.

The chart below compares TPCH queries executed in my local environment. It illustrates execution times before disabling the metastore cache, the current master, and after the optimization introduced in this PR.

image

Impact

No user impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Connector Changes
* Optimize redundant getTable calls in Iceberg Connector :pr:`12345`

@imjalpreet imjalpreet self-assigned this Jan 16, 2025
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 16, 2025
@prestodb-ci prestodb-ci requested review from a team, BryanCutler and nishithakbhaskaran and removed request for a team January 16, 2025 15:22
@imjalpreet imjalpreet force-pushed the reduceGetTableIceberg branch from e24d787 to 219ef2e Compare January 18, 2025 10:27
@imjalpreet imjalpreet force-pushed the reduceGetTableIceberg branch from 219ef2e to 70fe67e Compare January 18, 2025 13:08
@imjalpreet imjalpreet marked this pull request as ready for review January 18, 2025 16:28
@imjalpreet imjalpreet requested review from hantangwangd, ZacBlanco and a team as code owners January 18, 2025 16:28
@imjalpreet imjalpreet requested a review from presto-oss January 18, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants