Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt the Include-What-You-Use for presto_cpp/main/common/ #24359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adopt the Include-What-You-Use for presto_cpp/main/common/ #24359

wants to merge 1 commit into from

Conversation

anandamideShakyan
Copy link
Contributor

Description

Adopt the Include-What
Propose to 1) adopt Include-What-You-Use (IWYU) for header files, and 2) link what-you-use in CMakeList.

Motivation and Context

Clean Build
Screenshot 2025-01-14 at 10 52 48 AM

Incremental Build
Screenshot 2025-01-14 at 10 53 59 AM

Separate Test Target
Screenshot 2025-01-14 at 10 54 21 AM

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

@anandamideShakyan anandamideShakyan requested a review from a team as a code owner January 14, 2025 05:26
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 14, 2025
@prestodb-ci prestodb-ci requested review from a team, bibith4 and pratyakshsharma and removed request for a team January 14, 2025 05:27
zuyu
zuyu requested changes Jan 17, 2025
View reviewed changes
presto-native-execution/presto_cpp/main/common/CMakeLists.txt
target_link_libraries(presto_exception velox_exception)
set_property(TARGET presto_exception PROPERTY JOB_POOL_LINK
presto_link_job_pool)
target_link_libraries(presto_common_ConfigReader velox_common_config velox_exception)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use one whitespace instead of two.

ditto below

presto-native-execution/presto_cpp/main/common/tests/CMakeLists.txt
presto_common_BaseVeloxQueryConfigTest
presto_common_ConfigReader
presto_common_Configs
GTest::gtest_main)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuyu zuyu zuyu requested changes

@bibith4 bibith4 Awaiting requested review from bibith4 bibith4 was automatically assigned from prestodb/ibm-reviewers

@pratyakshsharma pratyakshsharma Awaiting requested review from pratyakshsharma pratyakshsharma was automatically assigned from prestodb/ibm-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandamideShakyan @zuyu @prestodb-ci