[native] Switch to using the Velox mono static library #24343
+13
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
ScrapCodes and
imsayari404
and removed request for
a team
majetideepak
changed the title
majetideepak
previously approved these changes
Jan 9, 2025
This change makes use of the Velox mono library for non-test related components. This removes the need to add individual velox subcomponent libraries and cuts down on the linking size because symbols are duplicated. When adding new non-test velox dependencies use the velox library rather than the individual velox component. For tests, the velox components are still needed to be separately used.
Most customers use parquet so prestissimo should always be built with parquet support.
czentgr
force-pushed
the
cz_switch_to_mono_velox_lib
branch
from
806687a to
8ec8753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes use of the Velox mono library for non-test related components. This removes the need to add individual velox subcomponent libraries and cuts down on the linking size because symbols are duplicated.
When adding new non-test velox dependencies use the velox library rather than the individual velox component.
For tests, the velox components are still needed to be separately used.
The sum of all the velox library components for clang on macOS with debug symbols is about 3.3GB. The velox mono library only consumes about 2.9GB resulting in a saving of about 400MB when switching over.
Similar results are to be expected on Linux and the release build (the latter saving is less because overall there would be less added code).
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.