Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Terminate Velox macro calls with semicolon #23681

Closed
wants to merge 1 commit into from
Closed

[native] Terminate Velox macro calls with semicolon #23681

wants to merge 1 commit into from

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Sep 19, 2024

Description

A follow-up PR for #23588, to fix build issues on macOS, as facebookincubator/velox#10914 has merged.

Release Notes

== NO RELEASE NOTE ==

@zuyu zuyu requested a review from a team as a code owner September 19, 2024 02:12
yingsu00
yingsu00 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuyu Any other places that need to be updated?

@zuyu
Copy link
Contributor Author

zuyu commented Sep 19, 2024

W/ this PR, all cxx tests and presto_server builds on macOS. I'm NOT sure if there are more places need to fix though.

@zuyu zuyu force-pushed the velox-macro-semicolon branch 2 times, most recently from b7e3c26 to 939b84a Compare September 20, 2024 15:10
@zuyu zuyu closed this Sep 21, 2024
@zuyu zuyu deleted the velox-macro-semicolon branch September 21, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingsu00 yingsu00 yingsu00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuyu @yingsu00