Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid confusion between ErrorCode and ErrorCodeSupplier #23678

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Sep 18, 2024

Description

errorCode --> errorCodeSupplier; match names to types

Motivation and Context

This briefly confused me when I was reading code

Impact

none

Test Plan

mvn test

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo marked this pull request as ready for review September 20, 2024 12:56
@elharo elharo requested a review from a team as a code owner September 20, 2024 12:56
@elharo elharo merged commit 98ff012 into master Sep 24, 2024
56 checks passed
@elharo elharo deleted the suply branch September 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants