Cleaning up code #897
Cleaning up code #897
Conversation
2. Fixed the installation of the linter to the one recommended by the developer
…a the Dialect type
2. Preparing to remove redundant `database.Store` and `database.StoreExtender` interfaces (partially put into pressly#898)
…oring-dialects # Conflicts: # internal/dialectquery/dialectquery.go
2. Fixed tests - sometimes they did not have time to close the database before cleaning
|
@mfridman could you take a look at the draft before I finish it? |
|
This will be a no-go in the /v3 of goose. It's got breaking changes, and this is something we take very seriously. I.e., we cannot break users unless we cut a major /v4 version. I am happy to accept some of these changes, like the golangci and any test fixes. But these should be broken down into smaller PRs to make reviewing easier. For some of the bigger changes, like moving code around/renaming/etc., I'd like to understand the rationale. Is it code readability, prefactor to support new features (in a backwards-compatible way), buf fixes, etc. To avoid doing a bunch of work, it'd be helpful to get a discussion going first to see what's in/out of scope. |
|
Yes, I haven't corrected the version of the package - I'll make adjustments. For the rest, I'll put them in separate PRs and start a discussion |
|
started a discussion: #902 |
2. Removed `StoreController` 3. Refactoring the migration version entity - added zero and no version
# Conflicts: # migrate.go
discussion: #902
Fixed the installation of the linter to the one recommended by the developer(moved to a separate PR; Fixed the installation of the linter #901 )Added the ability to set a dialect not only via a string, but also via the Dialect type(moved to a separate PR: Dialect refactoring #914)databaseStoreControllerSome of the changes were proposed in #898