Make provisioning scripts run in unprivileged mode + more #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to solve #16 and simplify unreasonably complicated commands such as
or
Apparently, Vagrant runs as
root
by default, which complicated everything, but it also provides aprivileged: false
mode:The scripts now make much much more sense and are pretty much ready to use with any other environment (Docker, GitHub Actions, or even as installation examples).
I changed the hashbang to
#!/usr/bin/env bash
, as the Vagrant documentation was using that, I am using a bash feature (grouping echo commands), and it is still quite portable.At the end of the
Vagrantfile
, the provisioner deletes all compiled object files in home, to save space (scriptcleanup.sh
). We were already doing this for SU2 before. This step is commented-out by default, to facilitate development. It is mainly relevant for the packaged box.All scripts are formatted and checked with shellcheck.
Summary:
fenics-ufl
is not needed anymore.After merging, update the website:
install-vscode.sh
vagrant ssh
andvagrant ssh -- -Y
(not related, but we don't advertise this)