Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default profiling explicitly in xml configs #618

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Feb 18, 2025

To raise awareness of this option and have a starting point for potential modifications.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@davidscn
Copy link
Member Author

@MakisH do you think it is a good idea to include it everywhere, e.g., also the quickstart?

@MakisH
Copy link
Member

MakisH commented Feb 20, 2025

@MakisH do you think it is a good idea to include it everywhere, e.g., also the quickstart?

Since profiling does not make anything more complicated or more prone to dependency issues (right?), then I think consistency would be better and have it everywhere.

Thanks for asking, I did not notice you did not update the Quickstart.

@davidscn davidscn merged commit 41fbd92 into develop Feb 20, 2025
1 check passed
@davidscn davidscn deleted the add-profiling branch February 20, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants