-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several updates to the Micro Manager config files #609
base: develop
Are you sure you want to change the base?
Several updates to the Micro Manager config files #609
Conversation
…Micro Manager config files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I have not tested it.
@MakisH Should we document the version dependency somewhere? (We now require the newest develop branch of the Micro Manager)
Co-authored-by: Benjamin Uekermann <[email protected]>
Currently we have the Micro Manager version in the requirements.txt of the respective micro participants. There should be a way to directly define the develop branch as a version. I will have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense to me.
@MakisH Should we document the version dependency somewhere? (We now require the newest develop branch of the Micro Manager)
As also stated in precice/micro-manager#133, these changes are breaking for the micro manager, but it is still in the v0.x cycle, so this is totally fine.
I think that requiring the newest develop is fine in this case, because it is experimental software. However, this will lead to unreproducible results, and if we add this case to the system tests, for example, they might often fail because of the different version. The usual tradeoff.
What we should remember would be to fix the version in before we do a Distribution release. I opened an issue for discussing the how: #610
I think that a statement in the README of the case that explains the following would be helpful:
- The case automatically gets the latest version, which might trigger issues if it is newer if it is newer than the tutorials version.
- Which set of versions this is known to work with and how to set them.
Holding off on merging this until a release of the Micro Manager is done. As the Micro Manager is still in initial development, releases are done rather flexibly and frequently. Hence it makes sense to release the Micro Manager and point to a release in the |
Both options, pointing to develop or new release, are OK for me. Depends probably on the frequency of such changes. |
This PR updates the following things in the Micro Manager config file:
config_file_name
toprecice_config_file_name
to clearly differentiate between the Micro Manager config and the preCICE config files. Introduced in #133scalar
andvector
values to data name keys in the Micro Manager config files as they are no longer necessary since #142Additionally, the
requirements.txt
intwo-scale-heat-conduction
now points to the develop branch of the Micro Manager repository, as the changes above are not in a release.Checklist:
changelog-entries/<PRnumber>.md
.