Update dependency in debian package recipe #124
Conversation
| env: # Versioning is "calculix-preciceX_2.YY-Z[...]" with X the major preCICE version, YY the minor CCX version and Z the package version | ||
| PACKAGE_NAME: "calculix-precice3_2.20.1-1_amd64" |
There was a problem hiding this comment.
Since we are only changing the Debian package details, the most appropriate here would be 2.20.1-2. But it probably does not matter anywhere.
There was a problem hiding this comment.
I changed this because we are bumping the version and doing a new release. 2.20.1 is the actual adapter version, right?
There was a problem hiding this comment.
- v2.20: CalculiX version
- v2.20.1: The second adapter we release that is made for v2.20 (previous was v2.20.0)
- v2.20.1-1: The first Debian package release (revision) of v2.20.1
- v2.20.1-2: The second Debian package release (revision) of v2.20.1.
There was a problem hiding this comment.
By this logic we should not release. Because we are not changing the adapter, but just a dependency of the Debian package.
There was a problem hiding this comment.
I would actually prefer that. Let's rename this PR, still merge it, and update the Debian packages in the release with a note, in case the previous ones were broken.
IshaanDesai
changed the title
|
I renamed the branch locally and pushed it and then deleted the old branch, which led GitHub to automatically close the pull request. I thought it would move the base branch to the new one, but apparently this does not work. Now I opened a new PR: #126 |
This release is necessary because an old reference to
libprecice2was leftover in the previous release v2.20.1. Fix in #123