Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hooks): removed usage of useMemo instead using useConst implemented with useRef #543

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danilocastro-shopify
Copy link

Proposing to prevent using hooks based on array dependency to simplify data lifecycle.

  • It does not create multiple empty arrays for future GC collection
  • Simple check to create the instance

Maybe this change is small and not worthy. Considering the usage of several hooks around the application, it would reduce the GC time slices.

Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: 1f4aba5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for preact-signals-demo failed.

Name Link
🔨 Latest commit 1f4aba5
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6605984058bb800008446f4a

packages/preact/src/index.ts Outdated Show resolved Hide resolved
packages/react/runtime/src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for getting so late to this, can we add a changeset and rebase this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants