-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hooks): removed usage of useMemo instead using useConst implemented with useRef #543
base: main
Are you sure you want to change the base?
chore(hooks): removed usage of useMemo instead using useConst implemented with useRef #543
Conversation
|
❌ Deploy Preview for preact-signals-demo failed.
|
Co-authored-by: Jason Miller <[email protected]>
Co-authored-by: Jason Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for getting so late to this, can we add a changeset and rebase this branch?
Proposing to prevent using hooks based on array dependency to simplify data lifecycle.
Maybe this change is small and not worthy. Considering the usage of several hooks around the application, it would reduce the GC time slices.