Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused resolve dependency #136

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore: Remove unused resolve dependency #136

merged 2 commits into from
Jul 17, 2024

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Jul 17, 2024

The resolve dependency seems to be unused. It's added in #25 but not needed anymore since #50

rschristian
rschristian approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, mind updating the lock file while you're at it?

@bluwy
Copy link
Contributor Author

bluwy commented Jul 17, 2024

Sorry, got too excited 😄

@rschristian
Copy link
Member

No worries, this is probably the first time in my life that I've remembered the lockfile

Thanks for doing it!

@rschristian rschristian merged commit b47553c into preactjs:main Jul 17, 2024
1 check passed
@bluwy bluwy deleted the remove-resolve-dep branch July 17, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @rschristian @JoviDeCroock